[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up
From: |
Evgeny Voevodin |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up |
Date: |
Thu, 25 Oct 2012 07:06:37 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 |
Any other comments on the patches?
I didn't get the consensus. Do we need a pointer to tcg context?
As I said before, I didn't notice any slow-down with it.
On 10/23/2012 10:21 AM, Evgeny Voevodin wrote:
This set of patches moves global variables to tcg_ctx:
gen_opc_ptr
gen_opparam_ptr
gen_opc_buf
gen_opparam_buf
Build tested for all targets.
Execution tested on ARM.
I didn't notice any slow-down of kernel boot after this set was applied.
Changelog:
v1->v2:
Introduced TCGContext *tcg_cur_ctx global to use in those places where we don't
have an interface to pass pointer to tcg_ctx.
Code style clean-up
Evgeny (2):
tcg/tcg.h: Duplicate global TCG variables in TCGContext
TCG: Remove unused global variables
Evgeny Voevodin (5):
translate-all.c: Introduce TCGContext *tcg_cur_ctx
TCG: Use gen_opc_ptr from context instead of global variable.
TCG: Use gen_opparam_ptr from context instead of global variable.
TCG: Use gen_opc_buf from context instead of global variable.
TCG: Use gen_opparam_buf from context instead of global variable.
gen-icount.h | 2 +-
target-alpha/translate.c | 10 +-
target-arm/translate.c | 10 +-
target-cris/translate.c | 13 +-
target-i386/translate.c | 10 +-
target-lm32/translate.c | 13 +-
target-m68k/translate.c | 10 +-
target-microblaze/translate.c | 13 +-
target-mips/translate.c | 11 +-
target-openrisc/translate.c | 13 +-
target-ppc/translate.c | 11 +-
target-s390x/translate.c | 11 +-
target-sh4/translate.c | 10 +-
target-sparc/translate.c | 10 +-
target-unicore32/translate.c | 10 +-
target-xtensa/translate.c | 8 +-
tcg/optimize.c | 62 ++++----
tcg/tcg-op.h | 324 ++++++++++++++++++++---------------------
tcg/tcg.c | 85 ++++++-----
tcg/tcg.h | 11 +-
translate-all.c | 4 +-
21 files changed, 328 insertions(+), 323 deletions(-)
--
Kind regards,
Evgeny Voevodin,
Technical Leader,
Mobile Group,
Samsung Moscow Research Center,
e-mail: address@hidden
- [Qemu-devel] [PATCH v2 7/7] TCG: Remove unused global variables, (continued)
- [Qemu-devel] [PATCH v2 7/7] TCG: Remove unused global variables, Evgeny Voevodin, 2012/10/23
- [Qemu-devel] [PATCH v2 1/7] tcg/tcg.h: Duplicate global TCG variables in TCGContext, Evgeny Voevodin, 2012/10/23
- [Qemu-devel] [PATCH v2 2/7] translate-all.c: Introduce TCGContext *tcg_cur_ctx, Evgeny Voevodin, 2012/10/23
- [Qemu-devel] [PATCH v2 6/7] TCG: Use gen_opparam_buf from context instead of global variable., Evgeny Voevodin, 2012/10/23
- [Qemu-devel] [PATCH v2 4/7] TCG: Use gen_opparam_ptr from context instead of global variable., Evgeny Voevodin, 2012/10/23
- [Qemu-devel] [PATCH v2 5/7] TCG: Use gen_opc_buf from context instead of global variable., Evgeny Voevodin, 2012/10/23
- [Qemu-devel] [PATCH v2 3/7] TCG: Use gen_opc_ptr from context instead of global variable., Evgeny Voevodin, 2012/10/23
- Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up, Evgeny Voevodin, 2012/10/23
- Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up,
Evgeny Voevodin <=
- Re: [Qemu-devel] [PATCH v2 0/7] TCG global variables clean-up, Evgeny Voevodin, 2012/10/25