[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 01/26] blockdev: Introduce a default machine
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 01/26] blockdev: Introduce a default machine blockdev interface field, QEMUMachine->mach_if |
Date: |
Fri, 26 Oct 2012 11:53:13 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Jason Baron <address@hidden> writes:
> From: Jason Baron <address@hidden>
>
> The current QEMUMachine definition has a 'use_scsi' field to indicate if a
> machine type should use scsi by default. However, Q35 wants to use ahci by
> default. Thus, introdue a new field in the QEMUMachine defintion, mach_if.
>
> This field should be initialized by the machine type to the default interface
> type which it wants to use (IF_SCSI, IF_AHCI, etc.). If no mach_if is defined,
> or it is set to 'IF_DEFAULT' or 'IF_NONE', we currently assume IF_IDE.
>
> Please use 'static inline int get_mach_if(int mach_if)', when accesssing the
> new mach_if field.
[...]
> diff --git a/hw/boards.h b/hw/boards.h
> index a2e0a54..969fd67 100644
> --- a/hw/boards.h
> +++ b/hw/boards.h
> @@ -20,7 +20,7 @@ typedef struct QEMUMachine {
> const char *desc;
> QEMUMachineInitFunc *init;
> QEMUMachineResetFunc *reset;
> - int use_scsi;
> + int mach_if;
> int max_cpus;
> unsigned int no_serial:1,
> no_parallel:1,
[...]
> diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c
> index fd46ba2..c70eb69 100644
> --- a/hw/xilinx_zynq.c
> +++ b/hw/xilinx_zynq.c
> @@ -178,7 +178,7 @@ static QEMUMachine zynq_machine = {
> .name = "xilinx-zynq-a9",
> .desc = "Xilinx Zynq Platform Baseboard for Cortex-A9",
> .init = zynq_init,
> - .use_scsi = 1,
> + .if_default = IF_SCSI,
I doubt this compiles, and if it does, the compiler is mean to you :)
> .max_cpus = 1,
> .no_sdcard = 1
> };
[...]
- Re: [Qemu-devel] [PATCH v3 06/26] pc: Move ioapic_init() from pc_piix.c to pc.c, (continued)
- Re: [Qemu-devel] [PATCH v3 01/26] blockdev: Introduce a default machine blockdev interface field, QEMUMachine->mach_if,
Markus Armbruster <=
[Qemu-devel] [PATCH v3 09/26] pci: Add class 0xc05 as 'SMBus', Jason Baron, 2012/10/19
[Qemu-devel] [PATCH v3 07/26] pc/piix_pci: factor out smram/pam logic, Jason Baron, 2012/10/19
[Qemu-devel] [PATCH v3 10/26] pcie: pass pcie window size to pcie_host_mmcfg_update(), Jason Baron, 2012/10/19
[Qemu-devel] [PATCH v3 11/26] pcie: Convert PCIExpressHost to use the QOM., Jason Baron, 2012/10/19
[Qemu-devel] [PATCH v3 12/26] ich9: Add acpi support and definitions, Jason Baron, 2012/10/19