[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 15/16] pseries: Fix bug in PCI MSI allocation
From: |
David Gibson |
Subject: |
[Qemu-devel] [PATCH 15/16] pseries: Fix bug in PCI MSI allocation |
Date: |
Tue, 30 Oct 2012 14:25:11 +1100 |
From: Alexey Kardashevskiy <address@hidden>
In one of the recent reworks to the XICS code, a bug was introduced where
we use the wrong sense and allocate level interrupts instead of message
interrupts for PCI MSIs. This patch fixes it.
Signed-off-by: Alexey Kardashevskiy <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
hw/spapr_pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c
index a08ed11..3c5b855 100644
--- a/hw/spapr_pci.c
+++ b/hw/spapr_pci.c
@@ -351,7 +351,7 @@ static void rtas_ibm_change_msi(sPAPREnvironment *spapr,
/* There is no cached config, allocate MSIs */
if (!phb->msi_table[ndev].nvec) {
- irq = spapr_allocate_irq_block(req_num, true);
+ irq = spapr_allocate_irq_block(req_num, false);
if (irq < 0) {
fprintf(stderr, "Cannot allocate MSIs for device#%d", ndev);
rtas_st(rets, 0, -1); /* Hardware error */
--
1.7.10.4
- [Qemu-devel] [0/16] pseries and PPC pending patches, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 01/16] Revert "PPC: pseries: Remove hack for PIO window", David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 04/16] pseries: Clean up inconsistent variable name in xics.c, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 12/16] target-pcc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 09/16] pseries: Allow RTAS tokens without a qemu handler, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 08/16] pseries: Return the token when we register an RTAS call, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 03/16] target-ppc: Extend FPU state for newer POWER CPUs, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 16/16] pseries: Generate unique LIOBNs for PCI host bridges, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 05/16] pseries: Use #define for XICS base irq number, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 06/16] pseries: Cleanup duplications of ics_valid_irq() code, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 15/16] pseries: Fix bug in PCI MSI allocation,
David Gibson <=
- [Qemu-devel] [PATCH 10/16] pseries: Add tracepoints to the XICS interrupt controller, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 02/16] target-ppc: Rework storage of VPA registration state, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 13/16] pseries: Implement PAPR NVRAM, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 07/16] pseries: Move XICS initialization before cpu initialization, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 11/16] pseries: Split xics irq configuration from state information, David Gibson, 2012/10/29
- [Qemu-devel] [PATCH 14/16] pseries: Update SLOF for NVRAM support, David Gibson, 2012/10/29