Re: [Qemu-devel] [PATCH v1 0/8] Sysbus EHCI + Zynq USB.

[Gerd Hoffmann]

On 10/29/12 15:08, Peter Crosthwaite wrote:
> Ping!
> 
> This is the first version of the EHCI sysbus series which takes a
> property based approach rather than the dynamic class approach.
> 
> No refactoring of the PCI stuff is done here (introduced v2) but
> following on from the discussion on IRC about how to do and the
> suggestion we take a property based approach, could we get a review of
> this and mix and match between this and V3 for the solution?

I like the EHCI{Pci,Sysbus}State approach in the v3 series, also the
sysbus restruction so sysbus_create_simple() can be used in v2+.

I'd suggest to drop all the controversial stuff:

 - v3 patch #1 (go with NULL like ohci does for the time being,
   when we finally figured+agreed on how to fix it we can change
   both ehci+ohci).
 - v3 patch #2 (class_data for pci).

With patch #2 being gone patch #6 needs to be changed too of course.
Just do it the classic way for now and lets worry later about how to
dynamically generate variants.

Have you tested the patch for the unmapped-register access I've sent?

cheers,
  Gerd