[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] 64-on-32 TCG broken
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] 64-on-32 TCG broken |
Date: |
Wed, 31 Oct 2012 15:05:37 +0100 |
On 31 October 2012 15:01, Paolo Bonzini <address@hidden> wrote:
> Thanks! In general, do not rebase a branch unless you were able to test
> the rebase fully. Use "git merge" instead. This does not apply to
> people without commit access (unless they use pull requests---perhaps we
> should use them more), but it is easy for you.
>
> If you hadn't rebased the series, "git bisect" would have pointed out
> that the original series worked, and that the merge was the problem.
I don't think this actually gains us anything, because we've still
checked broken code into master, whether it was via a rebase or a
merge. The correct answer is "test your commits before sending them",
surely?
-- PMM
- [Qemu-devel] x86_64-softmmu broken on Windows (TCG?), Paolo Bonzini, 2012/10/29
- Re: [Qemu-devel] x86_64-softmmu broken on Windows (TCG?), Aurelien Jarno, 2012/10/29
- [Qemu-devel] 64-on-32 TCG broken [was Re: x86_64-softmmu broken on Windows (TCG?)], Paolo Bonzini, 2012/10/30
- Re: [Qemu-devel] 64-on-32 TCG broken, Stefan Weil, 2012/10/30
- Re: [Qemu-devel] 64-on-32 TCG broken, Aurelien Jarno, 2012/10/30
- Re: [Qemu-devel] 64-on-32 TCG broken, Aurelien Jarno, 2012/10/30
- Re: [Qemu-devel] 64-on-32 TCG broken, Aurelien Jarno, 2012/10/31
- Re: [Qemu-devel] 64-on-32 TCG broken, Paolo Bonzini, 2012/10/31
- Re: [Qemu-devel] 64-on-32 TCG broken,
Peter Maydell <=
- Re: [Qemu-devel] 64-on-32 TCG broken, Paolo Bonzini, 2012/10/31
- Re: [Qemu-devel] 64-on-32 TCG broken, Aurelien Jarno, 2012/10/31
- Re: [Qemu-devel] 64-on-32 TCG broken, Stefan Weil, 2012/10/31
- Re: [Qemu-devel] 64-on-32 TCG broken, Aurelien Jarno, 2012/10/31