Re: [Qemu-devel] [PATCH] ui/cocoa.m: Update to new DisplayChangeListener member names

[Anthony Liguori]

Andreas Färber <address@hidden> writes:

> Hi,
>
> Am 02.11.2012 16:41, schrieb Gerd Hoffmann:
>>> (I have a philosophical preference for compile fixes being applied
>>> directly and quickly to master but my opinion on that matter is
>>> not particularly significant :-))
>> 
>> /me too.  Build fixes should go in on the fast track.  First because a
>> broken build is annonying.  Second because buildbots are less useful if
>> builds are broken for longer periods.
>
> Fine with me, less work. We should cc a maintainer then. ;)
>
>> One of the reasons I didn't notice the xenfb breakage was because the
>> fedora build is broken for other reasons, so the buildbot doesn't came
>> to the point where it tries to build xenfb.c and figures it doesn't.
>> 
>> Should we maybe agree on a special buildfix patch subject tag, so
>> maintainers can easily filter and prioritize them?
>
> I used [PATCH buildfix] or so in the past.

Not all build errors are created equal.

It's impossible for me to build cocoa support without physical Apple
hardware.

In this case, the cocoa maintainer (Andreas) should send an urgent pull
request to ensure the patch is properly tested.

I'm applying right now, so no worries this time, but if you are a
submaintainer, if there is something you consider urgent, you should
send a pull request.

Regards,

Anthony Liguori

>
> Regards,
> Andreas