[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC |
Date: |
Mon, 12 Nov 2012 10:38:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.10) Gecko/20121026 Thunderbird/10.0.10 |
Hi,
>> I'd go for clipping rather than asserting too (no crash) in all layers
>> as a defensive approach (console.c/vnc.c).
>
> Won't that be an unnecessary slowdown?
Thats why I tend to prefer assert for additional sanity checks. They
help finding bugs, but can optionally be compiled out.
But adding new asserts just before a release isn't the smartest move
indeed, maybe clip now and turn the checks into asserts once 1.3 is out
of the door.
cheers,
Gerd
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, (continued)
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Michael Tokarev, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Gerhard Wiesinger, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Peter Maydell, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Anthony Liguori, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Peter Maydell, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Gerd Hoffmann, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Marek Vasut, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Peter Maydell, 2012/11/09
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Gerhard Wiesinger, 2012/11/10
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Marek Vasut, 2012/11/10
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Gerd Hoffmann, 2012/11/12
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, BALATON Zoltan, 2012/11/12
- Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC, Blue Swirl, 2012/11/10