Re: [Qemu-devel] [PATCH 1/6] pixman: add output dir to include path

[Gerd Hoffmann]

On 11/14/12 09:40, Gerd Hoffmann wrote:
>>> >> +  pixman_cflags="-I${source_path}/pixman/pixman -I$(pwd)/pixman/pixman"
>>> >> +  pixman_libs="-L$(pwd)/pixman/pixman/.libs -lpixman-1"

>> > 
>> > I'd prefer \$(BUILD_DIR) instead of $(pwd) for cflags and libs
>> > because it allows moving the build directory.

> It isn't that simple.  Blue Swirl had it that way initially.  The
> problem is that pixman_cflags is added to QEMU_CFLAGS, which in turn is
> used by configure script checks too, which then blow up because make and
> shell interpret "$(BUILD_DIR)" in different ways ...

Moving the lines which update QEMU_CFLAGS down the road, after all
configure checks works though.

cheers,
  Gerd