[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h |
Date: |
Wed, 14 Nov 2012 15:03:34 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121025 Thunderbird/16.0.2 |
Am 09.11.2012 15:56, schrieb Eduardo Habkost:
> module.h is where machine_init() is defined, but qemu-fsdev-dummy.c
> doesn't include it.
>
> The header is probably being included by accident because some other
> headers are including qemu-common.h, but those headers should eventually
> stop including qemu-common.h.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
Acked-by: Andreas Färber <address@hidden>
I'm surprised about this machine_init() use case outside a machine though...
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 00/24] CPU DeviceState v7, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 02/24] user: rename qemu-types.h to qemu-user-types.h, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 15/24] qlist.h: do not include qemu-common.h, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 20/24] qdev: add weak aliases for vmstate handling on qdev.c, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 12/24] qga/channel-posix.c: include headers it needs, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h, Eduardo Habkost, 2012/11/09
- Re: [Qemu-devel] [PATCH 07/24] qemu-fsdev-dummy.c: include module.h,
Andreas Färber <=
- [Qemu-devel] [PATCH 23/24] include qdev code into *-user, too, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 24/24] qom: make CPU a child of DeviceState, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 14/24] sysemu.h: include qemu-types.h instead of qemu-common.h, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 16/24] qapi-types.h: don't include qemu-common.h, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 21/24] qdev: add weak alias to sysbus_get_default() on qdev.c, Eduardo Habkost, 2012/11/09
- [Qemu-devel] [PATCH 04/24] move qemu_irq typedef out of cpu-common.h, Eduardo Habkost, 2012/11/09