qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman


From: Wenchao Xia
Subject: Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman
Date: Fri, 16 Nov 2012 18:27:43 +0800
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20121026 Thunderbird/16.0.2

于 2012-11-16 18:16, Peter Maydell 写道:
On 16 November 2012 10:08, Wenchao Xia <address@hidden> wrote:
于 2012-11-16 17:27, Peter Maydell 写道:
On 16 November 2012 05:05, Wenchao Xia <address@hidden> wrote:
-       test -f pixman/config.log && make -C pixman distclean
+       @if test -f pixman/config.log; \
+       then \
+               make -C pixman distclean;\
+       fi

These two bits of shellscript both do the same thing, don't they?

   Looks the same, but on my machine
make -C pixman distclean
got executed resulting error, I guess that is what original author
wants to avoid.

If your shell executes Y in "X && Y" even if X fails, then your
shell is badly badly broken. More likely, there is some other
problem, and you need to find out what it is.
I don't think this patch should be applied, I'm afraid.

-- PMM

  My shell is OK, I missed the error reporting source before,
in my test I think it is first part reporting error, that
is "test -f pixman/config.log" directly report error.
  This patch would eliminate this error.

--
Best Regards

Wenchao Xia




reply via email to

[Prev in Thread] Current Thread [Next in Thread]