[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/8] dataplane: add host memory mapping code
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/8] dataplane: add host memory mapping code |
Date: |
Wed, 21 Nov 2012 08:59:00 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Nov 20, 2012 at 01:24:08PM -0500, Don Koch wrote:
> On 11/20/2012 07:31 AM, Stefan Hajnoczi wrote:
> > +void hostmem_init(Hostmem *hostmem)
> > +{
> > + memset(hostmem, 0, sizeof(*hostmem));
> > +
> > + hostmem->listener = (MemoryListener){
> > + .begin = hostmem_listener_nop,
> > + .commit = hostmem_listener_commit,
> > + .region_add = hostmem_listener_region_add,
> > + .region_del = hostmem_listener_section_nop,
> > + .region_nop = hostmem_listener_region_add,
> Really?
Yes. I will rename the function in the next version of the patch to
make it clear this is correct.
Since we rebuild the entire regions list on every update transaction, we
care about the "nop" (unchanged) regions too. They need to be added to
the new list we're building.
The deleted regions are ignored because we're building a new regions
list from scratch anyway.
Stefan
[Qemu-devel] [PATCH v2 4/8] dataplane: add virtqueue vring code, Stefan Hajnoczi, 2012/11/20
[Qemu-devel] [PATCH v2 5/8] dataplane: add event loop, Stefan Hajnoczi, 2012/11/20
[Qemu-devel] [PATCH v2 8/8] virtio-blk: add x-data-plane=on|off performance feature, Stefan Hajnoczi, 2012/11/20
[Qemu-devel] [PATCH v2 7/8] dataplane: add virtio-blk data plane code, Stefan Hajnoczi, 2012/11/20