[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 comp
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers |
Date: |
Wed, 21 Nov 2012 15:00:47 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
mingw32 with gcc up to (at least) 4.4 has broken __thread support.
This means all __thread variables silently become global ones.
Address this by switching the coroutine implementation for win32 to
Get/SetTlsValue.
Signed-off-by: Jan Kiszka <address@hidden>
---
coroutine-win32.c | 29 ++++++++++++++++++++++-------
1 files changed, 22 insertions(+), 7 deletions(-)
diff --git a/coroutine-win32.c b/coroutine-win32.c
index 4179609..bf0aeac 100644
--- a/coroutine-win32.c
+++ b/coroutine-win32.c
@@ -33,8 +33,7 @@ typedef struct
CoroutineAction action;
} CoroutineWin32;
-static __thread CoroutineWin32 leader;
-static __thread Coroutine *current;
+static int current_tls_index = TLS_OUT_OF_INDEXES;
CoroutineAction qemu_coroutine_switch(Coroutine *from_, Coroutine *to_,
CoroutineAction action)
@@ -42,7 +41,7 @@ CoroutineAction qemu_coroutine_switch(Coroutine *from_,
Coroutine *to_,
CoroutineWin32 *from = DO_UPCAST(CoroutineWin32, base, from_);
CoroutineWin32 *to = DO_UPCAST(CoroutineWin32, base, to_);
- current = to_;
+ TlsSetValue(current_tls_index, to_);
to->action = action;
SwitchToFiber(to->fiber);
@@ -79,14 +78,30 @@ void qemu_coroutine_delete(Coroutine *co_)
Coroutine *qemu_coroutine_self(void)
{
- if (!current) {
- current = &leader.base;
- leader.fiber = ConvertThreadToFiber(NULL);
+ CoroutineWin32 *leader;
+
+ if (current_tls_index == TLS_OUT_OF_INDEXES) {
+ current_tls_index = TlsAlloc();
+ if (current_tls_index == TLS_OUT_OF_INDEXES) {
+ fprintf(stderr, "qemu: %s: out of TLS handles\n", __func__);
+ abort();
+ }
+ }
+ if (!TlsGetValue(current_tls_index)) {
+ leader = g_malloc0(sizeof(*leader));
+ leader->fiber = ConvertThreadToFiber(NULL);
+ TlsSetValue(current_tls_index, &leader->base);
}
- return current;
+ return TlsGetValue(current_tls_index);
}
bool qemu_in_coroutine(void)
{
+ Coroutine *current;
+
+ if (current_tls_index == TLS_OUT_OF_INDEXES) {
+ return false;
+ }
+ current = TlsGetValue(current_tls_index);
return current && current->caller;
}
--
1.7.3.4
- [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers,
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers, Paolo Bonzini, 2012/11/21
- Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers, Jan Kiszka, 2012/11/21
- Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers, malc, 2012/11/21
- Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers, Paolo Bonzini, 2012/11/21
- Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers, Jan Kiszka, 2012/11/21
- Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers, Jan Kiszka, 2012/11/21
- Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers, Paolo Bonzini, 2012/11/21
- Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers, Jan Kiszka, 2012/11/21
- Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers, Stefan Weil, 2012/11/21
- Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers, Paolo Bonzini, 2012/11/22