[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] virtio-scsi Fix some endian bugs with virtio-sc
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] virtio-scsi Fix some endian bugs with virtio-scsi |
Date: |
Fri, 23 Nov 2012 08:11:28 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Nov 23, 2012 at 04:08:44PM +1100, David Gibson wrote:
> The virtio-scsi specification does not specify the correct endianness for
> fields in the request structure. It's therefore best to assume that it is
> "guest native" endian since that's the (stupid and poorly defined) norm in
> virtio.
>
> However, the qemu device for virtio-scsi has no byteswaps at all, and so
> will break if the guest has different endianness from the host. This patch
> fixes it by adding tswap() calls for the sense_len and resid fields in
> the request structure. In theory status_qualifier needs swaps as well,
> but that field is never actually touched. The tag field is a uint64_t, but
> since its value is completely arbitrary, it might as well be uint8_t[8]
> and so it does not need swapping.
>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Paul 'Rusty' Russell <address@hidden>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/virtio-scsi.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>