Re: [Qemu-devel] [PATCH] target-xtensa: make sar_m32 global instead of local temp

[Max Filippov]

On Sat, Nov 24, 2012 at 2:59 PM, Aurelien Jarno <address@hidden> wrote:
> On Sat, Nov 24, 2012 at 04:51:36AM +0400, Max Filippov wrote:
>> This fixes the following assertion caused by local temp reaching the end
>> of TB in discarded state:
>>
>>   qemu-system-xtensa: tcg/tcg.c:1665: temp_save: Assertion 
>> `s->temps[temp].val_type == 2 || s->temps[temp].fixed_reg' failed.
>>   Aborted
>>
>> Signed-off-by: Max Filippov <address@hidden>
>> ---
>>  target-xtensa/cpu.h       |    1 +
>>  target-xtensa/translate.c |   28 ++++++++--------------------
>>  2 files changed, 9 insertions(+), 20 deletions(-)
>
> I have just send a patch to fix the issue in the TCG code instead (sorry
> for being so long, the last weeks have been quite busy). I think it is
> better than fixing the issue in target-xtensa.
>
> If it works for you, I'll commit it.

Works perfectly, thanks. (nothing to be sorry for, BTW).

And it seems to me that switch from local temp to global makes code a bit
cleaner. However, since it's no longer a fix I will hold it until 1.3 is out.

-- 
Thanks.
-- Max