[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-arm: use type_register() instead of type
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] target-arm: use type_register() instead of type_register_static() |
Date: |
Wed, 28 Nov 2012 19:30:08 +0000 |
On 28 November 2012 19:20, Eduardo Habkost <address@hidden> wrote:
> The type_register_static() interface is documented as:
>
> type_register_static:
> @info: The #TypeInfo of the new type.
>
> @info and all of the strings it points to should exist for the life
> time that the type is registered.
>
> But cpu_register() uses a stack variable for the 'info' argument, so it
> has to use type_register() instead of type_register_static().
Reviewed-by: Peter Maydell <address@hidden>
though it seems a bit odd that we make this distinction in the
API even though type_register_static() just calls type_register()...
-- PMM