Re: [Qemu-devel] [PATCH for 1.3] qapi: Fix compiler warning caused by wrong type (32 bit hosts)

[Stefan Weil]

Am 27.11.2012 07:34, schrieb Stefan Weil:
> The function prototype of qapi_dealloc_type_size must match the
> declaration in qapi/qapi-visit-core.h:
>
> void (*type_size)(Visitor *v, uint64_t *obj, const char *name, Error **errp);
>
> Otherwise builds on hosts where size_t != uint64_t raise a compiler
> warning.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>
> Hi Anthony,
>
> this is an urgent build fix for 1.3.
>
> Regards
> Stefan
>
>   qapi/qapi-dealloc-visitor.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c
> index a07b171..75214e7 100644
> --- a/qapi/qapi-dealloc-visitor.c
> +++ b/qapi/qapi-dealloc-visitor.c
> @@ -132,7 +132,7 @@ static void qapi_dealloc_type_number(Visitor *v, double 
> *obj, const char *name,
>   {
>   }
>   
> -static void qapi_dealloc_type_size(Visitor *v, size_t *obj, const char *name,
> +static void qapi_dealloc_type_size(Visitor *v, uint64_t *obj, const char *name,
>                                      Error **errp)
>   {
>   }


Ping? Either this patch or http://patchwork.ozlabs.org/patch/202296/
should be committed to 1.3 asap.