[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 19/24] qdev: move reset handler list from vl.c t
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 19/24] qdev: move reset handler list from vl.c to qdev.c |
Date: |
Sat, 1 Dec 2012 11:26:02 +0000 |
On 30 November 2012 21:38, Eduardo Habkost <address@hidden> wrote:
> cpu_reset() is not that well-defined, otherwise we wouldn't have this on
> linux-user:
>
> #if defined(TARGET_I386) || defined(TARGET_SPARC) || defined(TARGET_PPC)
> cpu_reset(ENV_GET_CPU(env));
> #endif
>
> (I have no idea why we have that #ifdef).
I think this is because the different targets disagree about whether
the CPU should be reset on initial construction or whether it needs
a specific reset call. (The current setup with #ifdefs is among other
things a historical effect as a result of various refactorings in
the past; you can trace the git history if you're interested.)
-- PMM
- Re: [Qemu-devel] [PATCH 19/24] qdev: move reset handler list from vl.c to qdev.c,
Peter Maydell <=