Re: [Qemu-devel] [PATCH 6/7] target-mips: use DSP unions for reduction add instructions

[Johnson, Eric]

> -----Original Message-----
> From: address@hidden [mailto:qemu-devel-
> address@hidden On Behalf Of Aurelien Jarno
> Sent: Friday, November 16, 2012 3:04 AM
> To: address@hidden
> Cc: Aurelien Jarno
> Subject: [Qemu-devel] [PATCH 6/7] target-mips: use DSP unions for
> reduction add instructions
> 
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
>  target-mips/dsp_helper.c |   32 +++++++++++++++-----------------
>  1 file changed, 15 insertions(+), 17 deletions(-)
> 
> diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
> index 3bd2d35..474c249 100644
> --- a/target-mips/dsp_helper.c
> +++ b/target-mips/dsp_helper.c
> @@ -1381,31 +1381,29 @@ target_ulong helper_modsub(target_ulong rs,
> target_ulong rt)
> 
>  target_ulong helper_raddu_w_qb(target_ulong rs)
>  {
> -    uint8_t  rs3, rs2, rs1, rs0;
> -    uint16_t temp;
> -
> -    MIPSDSP_SPLIT32_8(rs, rs3, rs2, rs1, rs0);
> -
> -    temp = (uint16_t)rs3 + (uint16_t)rs2 + (uint16_t)rs1 + (uint16_t)rs0;
> +    target_ulong ret = 0;
> +    DSP32Value ds;
> +    unsigned int i;
> 
> -    return (target_ulong)temp;
> +    ds.uw[0] = rs;
> +    for (i = 0 ; i < 4 ; i++) {
> +        ret += ds.ub[i];
> +    }
> +    return ret;
>  }
> 
>  #if defined(TARGET_MIPS64)
>  target_ulong helper_raddu_l_ob(target_ulong rs)
>  {
> -    int i;
> -    uint16_t rs_t[8];
> -    uint64_t temp;
> -
> -    temp = 0;
> +    target_ulong ret = 0;
> +    DSP64Value ds;
> +    unsigned int i;
> 
> -    for (i = 0; i < 8; i++) {
> -        rs_t[i] = (rs >> (8 * i)) & MIPSDSP_Q0;
> -        temp += (uint64_t)rs_t[i];
> +    ds.ul[0] = rs;
> +    for (i = 0 ; i < 8 ; i++) {
> +        ret += ds.ub[i];
>      }
> -
> -    return temp;
> +    return ret;
>  }
>  #endif
> 
> --
> 1.7.10.4
> 

Reviewed-by: Eric Johnson <address@hidden>