[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related f
From: |
li guang |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function |
Date: |
Thu, 06 Dec 2012 17:16:33 +0800 |
在 2012-12-06四的 08:54 +0000,Peter Maydell写道:
> On 6 December 2012 03:03, liguang <address@hidden> wrote:
> > Signed-off-by: liguang <address@hidden>
> > --- a/target-i386/seg_helper.c
> > +++ b/target-i386/seg_helper.c
> > @@ -465,9 +465,9 @@ static void switch_tss(CPUX86State *env, int
> > tss_selector,
> >
> > #ifndef CONFIG_USER_ONLY
> > /* reset local breakpoints */
> > - if (env->dr[7] & 0x55) {
> > - for (i = 0; i < 4; i++) {
> > - if (hw_breakpoint_enabled(env->dr[7], i) == 0x1) {
> > + if (env->dr[7] & DR7_LOCAL_BP_MASK) {
> > + for (i = 0; i < DR7_MAX_BP; i++) {
> > + if (hw_breakpoint_enabled(env->dr[7], i)) {
> > hw_breakpoint_remove(env, i);
> > }
> > }
>
> This is still wrong.
do you mean the use of 'hw_breakpoint_enabled'? or others?
maybe a mistake, I change it to 'hw_local_breakpoint_enabled'.
if it is I'll re-send a corrected patch.
Thanks!
> PS: if you could put the 'v2'/'v3' etc marking in the [PATCH]
> tags for the subjects of all the patch emails and not just the
> cover letter that would be helpful. git format-patch's
> --subject-prefix='PATCH v3' option should do this for you.
>
> -- PMM
--
regards!
li guang
- Re: [Qemu-devel] [PATCH 1/3] target-i386:define name of breakpoint bit in dr7, (continued)
- [Qemu-devel] [PATCH 1/3] target-i386:define name of breakpoint bit in dr7, liguang, 2012/12/05
- [Qemu-devel] [PATCH 2/3] target-i386:make hw_breakpoint_enabled return bool type, liguang, 2012/12/05
- [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function, liguang, 2012/12/05
- Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function, Peter Maydell, 2012/12/06
- Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function,
li guang <=
- Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function, Peter Maydell, 2012/12/06
- Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function, li guang, 2012/12/06
- Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function, Wei-Ren Chen, 2012/12/06
- Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function, Andreas Färber, 2012/12/06
- Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function, Peter Maydell, 2012/12/06
- Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function, Andreas Färber, 2012/12/06
- Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function, li guang, 2012/12/06
- Re: [Qemu-devel] [PATCH 3/3] target-i386:slightly refactor dr7 related function, Peter Maydell, 2012/12/06