[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pi
From: |
Ian Campbell |
Subject: |
Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move |
Date: |
Fri, 7 Dec 2012 16:30:43 +0000 |
On Fri, 2012-12-07 at 16:14 +0000, Ian Jackson wrote:
> + target_phys_addr_t offset = (target_phys_addr_t)req->size * i;
> + if (req->df) addr -= offset;
> + else addr -= offset;
One of these -= should be a += I presume?
[...]
> + write_phys_req_item((target_phys_addr_t) req->data, req, i,
> &tmp);
This seems to be the only one with this cast, why?
write_phys_req_item takes a target_phys_addr_t so this will happen
regardless I think.
Ian.