Re: [Qemu-devel] [PATCH 2/3 v4] vnc: added initial websocket protocol support

[Stefan Hajnoczi]

On Fri, Dec 07, 2012 at 03:56:34PM +0100, Tim Hardeck wrote:

Thanks for addressing my review comments.

> @@ -1328,13 +1358,14 @@ void vnc_client_read(void *opaque)
>  
>  void vnc_write(VncState *vs, const void *data, size_t len)
>  {
> -    buffer_reserve(&vs->output, len);
> +        buffer_reserve(&vs->output, len);
>  
> -    if (vs->csock != -1 && buffer_empty(&vs->output)) {
> -        qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read, 
> vnc_client_write, vs);
> -    }
> +        if (vs->csock != -1 && buffer_empty(&vs->output)) {
> +            qemu_set_fd_handler2(vs->csock, NULL, vnc_client_read,
> +                    vnc_client_write, vs);
> +        }
>  
> -    buffer_append(&vs->output, data, len);
> +        buffer_append(&vs->output, data, len);

QEMU uses 4 spaces for indentation.

Stefan