Re: [Qemu-devel] [RFC V3 02/24] qcow2: Add deduplication structures and fields.

[Stefan Hajnoczi]

On Mon, Nov 26, 2012 at 02:05:01PM +0100, Benoît Canet wrote:
> diff --git a/block/qcow2.h b/block/qcow2.h
> index b4eb654..e192001 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -58,6 +58,23 @@
>  
>  #define DEFAULT_CLUSTER_SIZE 65536
>  
> +/* deduplication node */
> +typedef struct {
> +    uint8_t *hash;         /* 32 bytes hash of a given cluster */

Pointer to the hash value instead of storing the value inline?  At this
point in the series I'm not sure yet why it's not stored inline.  That
way we'd avoid a 4- or 8-byte pointer to a separately allocated 32-byte
blob.  Maybe there is a reason later on...

Stefan