[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 34/35] ram: reuse ram_save_iterate() for the complet
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 34/35] ram: reuse ram_save_iterate() for the complete stage |
Date: |
Tue, 11 Dec 2012 13:47:10 +0100 |
This means that we only have one memory loop for the iterate and
complete phase.
Signed-off-by: Juan Quintela <address@hidden>
---
arch_init.c | 17 -----------------
migration.c | 12 ++++++++++++
2 files changed, 12 insertions(+), 17 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 6a4ee24..87aecf8 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -675,25 +675,8 @@ static int ram_save_iterate(QEMUFile *f, void *opaque,
uint64_t free_space)
static int ram_save_complete(QEMUFile *f, void *opaque)
{
- migration_bitmap_sync();
-
qemu_mutex_lock_ramlist();
-
- /* try transferring iterative blocks of memory */
-
- /* flush all remaining blocks regardless of rate limiting */
- while (true) {
- int bytes_sent;
-
- bytes_sent = ram_save_block(f);
- /* no more blocks to sent */
- if (bytes_sent == 0) {
- break;
- }
- bytes_transferred += bytes_sent;
- }
memory_global_dirty_log_stop();
-
qemu_mutex_unlock_ramlist();
qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
diff --git a/migration.c b/migration.c
index d59f7b4..dd6a401 100644
--- a/migration.c
+++ b/migration.c
@@ -728,6 +728,18 @@ static void *buffered_file_thread(void *opaque)
} else {
vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
}
+
+ /* 8 is the size of an end of section mark, so empty section */
+ while ((ret = qemu_savevm_state_iterate(m->file, free_space))
+ > 8) {
+ ret = buffered_flush(s);
+ if (ret < 0) {
+ qemu_mutex_unlock_iothread();
+ break;
+ }
+ free_space = s->buffer_capacity - s->buffer_size;
+ }
+
ret = qemu_savevm_state_complete(m->file);
if (ret < 0) {
qemu_mutex_unlock_iothread();
--
1.7.11.7
- [Qemu-devel] [PATCH 25/35] ram: Add last_sent_block, (continued)
- [Qemu-devel] [PATCH 25/35] ram: Add last_sent_block, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 21/35] migration: Add buffered_flush error handling, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 27/35] ram: Use memory_region_test_and_clear_dirty, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 26/35] memory: introduce memory_region_test_and_clear_dirty, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 24/35] ram: rename last_block to last_seen_block, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 35/35] migration: print times for end phase, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 32/35] ram: add free_space parameter to save_live functions, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 30/35] ram: account the amount of transferred ram better, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 29/35] ram: optimize migration bitmap walking, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 31/35] ram: refactor ram_save_block() return value, Juan Quintela, 2012/12/11
- [Qemu-devel] [PATCH 34/35] ram: reuse ram_save_iterate() for the complete stage,
Juan Quintela <=
- Re: [Qemu-devel] [PATCH 00/35] Migration thread (20121211), Paolo Bonzini, 2012/12/11
- [Qemu-devel] [PATCH 33/35] ram: remove xbrle last_stage optimization, Juan Quintela, 2012/12/11