[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 04/12] dataplane: add virtqueue vring code
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v6 04/12] dataplane: add virtqueue vring code |
Date: |
Tue, 11 Dec 2012 16:18:20 +0200 |
On Mon, Dec 10, 2012 at 02:09:37PM +0100, Stefan Hajnoczi wrote:
> + iov->iov_base = hostmem_lookup(&vring->hostmem, desc.addr, desc.len,
> + desc.flags & VRING_DESC_F_WRITE);
> + if (!iov->iov_base) {
> + error_report("Failed to map indirect descriptor"
> + "addr %#" PRIx64 " len %u",
> + (uint64_t)desc.addr, desc.len);
> + vring->broken = true;
> + return -EFAULT;
> + }
> + iov->iov_len = desc.len;
> + iov++;
Hmm, this assumes a descriptor can not cross a memory
region boundary. Is this really guaranteed?
vhost does not make such assumptions.
--
MST
- Re: [Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code, (continued)
- Re: [Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code, Anthony Liguori, 2012/12/11
- Re: [Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code, Michael S. Tsirkin, 2012/12/11
- Re: [Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code, Stefan Hajnoczi, 2012/12/12
- Re: [Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code, Michael S. Tsirkin, 2012/12/12
- Re: [Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code, Stefan Hajnoczi, 2012/12/14
- Re: [Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code, Michael S. Tsirkin, 2012/12/16
- Re: [Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code, Stefan Hajnoczi, 2012/12/17
[Qemu-devel] [PATCH v6 05/12] dataplane: add event loop, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 07/12] iov: add iov_discard_front/back() to remove data, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 04/12] dataplane: add virtqueue vring code, Stefan Hajnoczi, 2012/12/10
- Re: [Qemu-devel] [PATCH v6 04/12] dataplane: add virtqueue vring code,
Michael S. Tsirkin <=
[Qemu-devel] [PATCH v6 06/12] dataplane: add Linux AIO request queue, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature, Stefan Hajnoczi, 2012/12/10
Re: [Qemu-devel] [PATCH v6 00/12] virtio: virtio-blk data plane, Stefan Hajnoczi, 2012/12/10
[Qemu-devel] [PATCH v6 02/12] configure: add CONFIG_VIRTIO_BLK_DATA_PLANE, Stefan Hajnoczi, 2012/12/10