[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API. |
Date: |
Wed, 12 Dec 2012 14:25:30 +0000 |
On 10 December 2012 16:45, <address@hidden> wrote:
> -static void virtio_blk_class_init(ObjectClass *klass, void *data)
> -{
> - DeviceClass *dc = DEVICE_CLASS(klass);
> - PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
> -
> - k->init = virtio_blk_init_pci;
> - k->exit = virtio_blk_exit_pci;
> - k->vendor_id = PCI_VENDOR_ID_REDHAT_QUMRANET;
> - k->device_id = PCI_DEVICE_ID_VIRTIO_BLOCK;
> - k->revision = VIRTIO_PCI_ABI_VERSION;
> - k->class_id = PCI_CLASS_STORAGE_SCSI;
> - dc->reset = virtio_pci_reset;
> - dc->props = virtio_blk_properties;
> -}
This hunk removes the setting of the PCI vendor and device IDs
but I can't see where they are set in the new code.
How will the PCI transport's PCI vendor/device/class IDs be
set (a) when a virtio-blk backend is created and separately
plugged into a virtio-pci transport (b) for the legacy
virtio-pci-blk? [ideally the answer to (b) should be "in the
same way as for (a)"]
-- PMM
- [Qemu-devel] [RFC PATCH v7 0/8] Virtio refactoring., fred . konrad, 2012/12/10
- [Qemu-devel] [RFC PATCH v7 1/8] qdev : add a maximum device allowed field for the bus., fred . konrad, 2012/12/10
- [Qemu-devel] [RFC PATCH v7 3/8] virtio-pci-bus : Introduce virtio-pci-bus., fred . konrad, 2012/12/10
- [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., fred . konrad, 2012/12/10
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., Peter Maydell, 2012/12/11
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.,
Peter Maydell <=
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., Andreas Färber, 2012/12/12
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., Paolo Bonzini, 2012/12/12
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., Peter Maydell, 2012/12/12
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., Paolo Bonzini, 2012/12/12
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., Michael S. Tsirkin, 2012/12/12
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., Paolo Bonzini, 2012/12/13
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., Anthony Liguori, 2012/12/13
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., Michael S. Tsirkin, 2012/12/16
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., KONRAD Frédéric, 2012/12/13
- Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API., Andreas Färber, 2012/12/16