[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/3] chardev: add error reporting for qemu_chr_new_f
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 1/3] chardev: add error reporting for qemu_chr_new_from_opts |
Date: |
Fri, 14 Dec 2012 10:38:01 +0100 |
Signed-off-by: Gerd Hoffmann <address@hidden>
---
qemu-char.c | 24 +++++++++++++++---------
qemu-char.h | 3 ++-
vl.c | 9 ++++++---
3 files changed, 23 insertions(+), 13 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 242b799..5b91228 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2766,19 +2766,20 @@ static const struct {
};
CharDriverState *qemu_chr_new_from_opts(QemuOpts *opts,
- void (*init)(struct CharDriverState *s))
+ void (*init)(struct CharDriverState *s),
+ Error **errp)
{
CharDriverState *chr;
int i;
if (qemu_opts_id(opts) == NULL) {
- fprintf(stderr, "chardev: no id specified\n");
+ error_setg(errp, "chardev: no id specified\n");
return NULL;
}
if (qemu_opt_get(opts, "backend") == NULL) {
- fprintf(stderr, "chardev: \"%s\" missing backend\n",
- qemu_opts_id(opts));
+ error_setg(errp, "chardev: \"%s\" missing backend\n",
+ qemu_opts_id(opts));
return NULL;
}
for (i = 0; i < ARRAY_SIZE(backend_table); i++) {
@@ -2786,15 +2787,15 @@ CharDriverState *qemu_chr_new_from_opts(QemuOpts *opts,
break;
}
if (i == ARRAY_SIZE(backend_table)) {
- fprintf(stderr, "chardev: backend \"%s\" not found\n",
- qemu_opt_get(opts, "backend"));
+ error_setg(errp, "chardev: backend \"%s\" not found\n",
+ qemu_opt_get(opts, "backend"));
return NULL;
}
chr = backend_table[i].open(opts);
if (!chr) {
- fprintf(stderr, "chardev: opening backend \"%s\" failed\n",
- qemu_opt_get(opts, "backend"));
+ error_setg(errp, "chardev: opening backend \"%s\" failed\n",
+ qemu_opt_get(opts, "backend"));
return NULL;
}
@@ -2824,6 +2825,7 @@ CharDriverState *qemu_chr_new(const char *label, const
char *filename, void (*in
const char *p;
CharDriverState *chr;
QemuOpts *opts;
+ Error *err = NULL;
if (strstart(filename, "chardev:", &p)) {
return qemu_chr_find(p);
@@ -2833,7 +2835,11 @@ CharDriverState *qemu_chr_new(const char *label, const
char *filename, void (*in
if (!opts)
return NULL;
- chr = qemu_chr_new_from_opts(opts, init);
+ chr = qemu_chr_new_from_opts(opts, init, &err);
+ if (error_is_set(&err)) {
+ fprintf(stderr, "%s\n", error_get_pretty(err));
+ error_free(err);
+ }
if (chr && qemu_opt_get_bool(opts, "mux", 0)) {
monitor_init(chr, MONITOR_USE_READLINE);
}
diff --git a/qemu-char.h b/qemu-char.h
index a121e04..d7eed34 100644
--- a/qemu-char.h
+++ b/qemu-char.h
@@ -89,7 +89,8 @@ struct CharDriverState {
* Returns: a new character backend
*/
CharDriverState *qemu_chr_new_from_opts(QemuOpts *opts,
- void (*init)(struct CharDriverState *s));
+ void (*init)(struct CharDriverState *s),
+ Error **errp);
/**
* @qemu_chr_new:
diff --git a/vl.c b/vl.c
index a3ab384..353817a 100644
--- a/vl.c
+++ b/vl.c
@@ -2057,11 +2057,14 @@ static int device_init_func(QemuOpts *opts, void
*opaque)
static int chardev_init_func(QemuOpts *opts, void *opaque)
{
- CharDriverState *chr;
+ Error *local_err = NULL;
- chr = qemu_chr_new_from_opts(opts, NULL);
- if (!chr)
+ qemu_chr_new_from_opts(opts, NULL, &local_err);
+ if (error_is_set(&local_err)) {
+ fprintf(stderr, "%s\n", error_get_pretty(local_err));
+ error_free(local_err);
return -1;
+ }
return 0;
}
--
1.7.1
- [Qemu-devel] [PATCH RESENT 0/3] chardev hotplug patch series, Gerd Hoffmann, 2012/12/14
- [Qemu-devel] [PATCH 2/3] chardev: fix QemuOpts lifecycle, Gerd Hoffmann, 2012/12/14
- [Qemu-devel] [PATCH 1/3] chardev: add error reporting for qemu_chr_new_from_opts,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Gerd Hoffmann, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Paolo Bonzini, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Eric Blake, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Gerd Hoffmann, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Paolo Bonzini, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Gerd Hoffmann, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Gerd Hoffmann, 2012/12/14
- Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support., Paolo Bonzini, 2012/12/14