Re: [Qemu-devel] [PATCH RFC] PowerPC: Added uapi directory into linux-header

[Bhushan Bharat-R65777]

> -----Original Message-----
> From: Alexander Graf [mailto:address@hidden
> Sent: Friday, December 14, 2012 5:06 PM
> To: Bhushan Bharat-R65777
> Cc: qemu-devel qemu-devel; address@hidden List; Bhushan Bharat-R65777; Jan
> Kiszka
> Subject: Re: [PATCH RFC] PowerPC: Added uapi directory into linux-header
> 
> 
> On 14.12.2012, at 12:04, Bharat Bhushan wrote:
> 
> > This is corrently done for powerpc.
> >
> > Signed-off-by: Bharat Bhushan <address@hidden>
> 
> Jan, could you please check if this is correct?
> 
> > ---
> > configure                       |    1 +
> > scripts/update-linux-headers.sh |    5 +++++
> > 2 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/configure b/configure
> > index 780b19a..bdc2d5e 100755
> > --- a/configure
> > +++ b/configure
> > @@ -3701,6 +3701,7 @@ if test "$linux" = "yes" ; then
> >     # For non-KVM architectures we will not have asm headers
> >     if [ -e "$source_path/linux-headers/asm-$linux_arch" ]; then
> >       symlink "$source_path/linux-headers/asm-$linux_arch"
> > linux-headers/asm
> > +      symlink "$source_path/linux-headers/uapi/asm-$linux_arch"
> > + linux-headers/uapi/asm
> >     fi
> > fi
> >
> > diff --git a/scripts/update-linux-headers.sh
> > b/scripts/update-linux-headers.sh index 4c7b566..9f6bf25 100755
> > --- a/scripts/update-linux-headers.sh
> > +++ b/scripts/update-linux-headers.sh
> > @@ -48,6 +48,11 @@ for arch in $ARCHLIST; do
> >
> >     rm -rf "$output/linux-headers/asm-$arch"
> >     mkdir -p "$output/linux-headers/asm-$arch"
> > +    if [ $arch = powerpc ]; then
> 
> This looks bogus. There shouldn't be any powerpc specifics anywhere in this
> file.

This file have x86 specific also, why ?

-Bharat

> 
> 
> Alex
> 
> > +   rm -rf $output/linux-headers/uapi/asm-$arch/*
> > +        cp "$linux/arch/$arch/include/uapi/asm/epapr_hcalls.h"
> "$output/linux-headers/uapi/asm-$arch/"
> > +    fi
> > +
> >     for header in kvm.h kvm_para.h; do
> >         cp "$tmpdir/include/asm/$header" "$output/linux-headers/asm-$arch"
> >     done
> > --
> > 1.7.0.4
> >
> >
>