qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] build: Use separate makefile for "trace/"


From: Lluís Vilanova
Subject: Re: [Qemu-devel] [PATCH] build: Use separate makefile for "trace/"
Date: Fri, 14 Dec 2012 14:46:46 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Paolo Bonzini writes:

>> > Yeah, make it
>> 
>> > oslib-obj-y += trace/
>> 
>> > and get rid of trace-obj-y.
>> 
>> Mmm, but according to Makefile.objs:
>> 
>> oslib-obj-y is code depending on the OS (win32 vs posix)

> True... I'd like to simplify this jungle sooner or later though.

> We can keep trace-obj-y, but please do leave out qemu-timer-common.o

Done, I'll send v2 later today.


[...]
>> > I'm sure this has already been previously discussed to the point of 
>> > extenuation,
>> > but what are the reasons for not using autotools?
>> 
>> > Autoconf -> no point, but someone needs to do the work.
>> 
>> > Automake -> the build system is just too different.
>> 
>> > Libtool -> using it already. :)
>> 
>> 
>> Ok, so it's not something against the suite per-se, but about porting work.
>> 
>> The thing I like about automake is that it provides a clear set of vars to
>> manage the per-dir builds, thanks to using a per-dir $(MAKE); but I'm
>> not sure how the per-target build would be managed (except by having a
>> separate configure+make for each of them).

> Yes, that would be it.

I'd certainly love to see something along those lines for the sake of makefile
simplicity.


> Even an autoconf conversion probably would have to use separate configure
> scripts for the global project and for each target.

If you're willing to pay for a complete recompilation for each target you can
just have a single configure file.


>> This could also be provided by having the QEMU build infrastructure use 
>> $(MAKE)
>> to enter into each directory, and having it produce an ar file (or a
>> set of them) with a "standard" name as a result (using libtool).

> Doesn't need to use libtool.  Static libraries are just fine.  The problem
> is that ar doesn't work well with constructors, which we use for module.c.
> It is what QEMU used to use, but Andreas moved away a couple of years ago
> and I think it is an improvement.

Ah, I know that one in gcc :)

  -Wl,--whole-archive foo.a -Wl,--no-whole-archive


Thanks,
  Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth



reply via email to

[Prev in Thread] Current Thread [Next in Thread]