Re: [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion

[Andreas Färber]

Am 15.12.2012 14:45, schrieb Julien Grall:
> On Fri, Dec 14, 2012 at 11:39 PM, Marcelo Tosatti <address@hidden> wrote:
>>
>>
>> The high byte of the ioport address is necessary to compute
>> the register address, see "82371AB PCI ISA IDE Xcelerator (PIIX4)"
>> document, eg:
>>
>> 4.2.1.1. DCOM—DMA Command Register (IO)
>> I/O Address: Channels 0–3—08h; Channels 4–7—0D0h
>>
> 
> I sent a patch on the mailing to resolve the problem yesterday
> (http://www.mail-archive.com/address@hidden/msg145242.html).
> Did it resolve your WinXp-32 installation? I just need to rework the comment.
> 
>>
>> Also the size of the region is wrong.
> 
> I don't think the size of the region is wrong. For the second DMA
> controller, the ioports are 0xD0 - 0xDE for the control registers.
> So the size is 16 not 8. It's the same for the channel registers.

You did seem to change it in size, if you compare my review questions,
without you mentioning why in the patch.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg