Re: [Qemu-devel] [PATCH 01/10] ide: Break all non-qdevified controllers

[Alexander Graf]

On 17.12.2012, at 15:43, Markus Armbruster wrote:

> Alexander Graf <address@hidden> writes:
> 
>> On 17.12.2012, at 15:05, Markus Armbruster wrote:
>> 
>>> They complicate IDE data structures and keep getting in the way.
>>> Also, TRIM support (commit d353fb72) is broken for them, because
>>> ide_identify() accesses IDEDevice member conf, but IDEDevice exists
>>> only with qdevified controllers.
>>> 
>>> The non-qdevified controllers are still there, but attempting to
>>> connect devices to them fails with "IDE controller not qdevified yet;
>>> drive <name> ignored".
>>> 
>>> Affected machines:
>>> 
>>> * g3beige's first IDE channel (MacIO)
>>> -hda, -hdb are on first channel, and no longer work
>>> -hdc, -hdd are on second channel, and still work
>>> * mac99's second and third IDE channel (MacIO)
>>> All four IDE drives no longer work
>> 
>> Nack. This breaks the default targets of qemu-system-ppc and 
>> qemu-system-ppc64.
> 
> Please tell us how much more time you want to qdevify IDE for these
> targets.  Thanks!

I don't know. If it's dear to you, just convert it yourself. Apparently you're 
quite deep into the details here already, so it's a lot easier for you than for 
me anyways.


Alex