Re: [Qemu-devel] [PATCH RfC 0/9] chardev hotplug

[Daniel P. Berrange]

On Thu, Dec 20, 2012 at 11:49:29AM +0100, Michal Privoznik wrote:
> On 19.12.2012 16:58, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > Chardev hotplug patch series reloaded.  Not finished yet, commit
> > messages not finalized yet, totally untested other than building on
> > linux+windows.
> > 
> > I doubt I manage to finish (and test!) it before xmas.  Nevertheless I
> > wanna get the bits out of the door for you to see what is coming and for
> > early reviews.  It goes largely the route suggested by Paolo.
> > 
> > cheers,
> >   Gerd
> > 
> > Gerd Hoffmann (9):
> >   chardev: add error reporting for qemu_chr_new_from_opts
> >   chardev: fix QemuOpts lifecycle
> >   chardev: reduce chardev ifdef mess a bit
> >   chardev: hotplug, qmp, null
> >   chardev: hotplug, hmp
> >   chardev: hotplug, qmp, file
> >   chardev: hotplug, qmp, tty
> >   chardev: hotplug, qmp, serial
> >   chardev: hotplug, qmp, parallel
> > 
> >  hmp-commands.hx  |   32 ++++++
> >  hmp.c            |   23 +++++
> >  hmp.h            |    2 +
> >  qapi-schema.json |   47 +++++++++
> >  qemu-char.c      |  280 
> > ++++++++++++++++++++++++++++++++++++++++++++---------
> >  qemu-char.h      |    4 +-
> >  qmp-commands.hx  |   50 ++++++++++
> >  vl.c             |    9 +-
> >  8 files changed, 395 insertions(+), 52 deletions(-)
> > 
> 
> Okay, the QMP interface seems sane to me (from libvirt POV). However,
> what about other chardev types like pipe and vc? And I guess pty can be
> covered by tty, right?

No, QEMU's  pty & tty types are different - the latter is about accessing
host serial devices

>From libvirt's POV, I think the most important chardev types are pty,
unix and tcp. The other types are pretty rarely used AFAICT.


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|