Re: [Qemu-devel] [PATCH 1/3] HMP: add QDict to info callback handler

[Markus Armbruster]

Wenchao Xia <address@hidden> writes:

>   This patch change all info call back function to take
> additional QDict * parameter, which allow those command
> take parameter.
[...]
> diff --git a/monitor.c b/monitor.c
> index c0e32d6..797680f 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -123,7 +123,7 @@ typedef struct mon_cmd_t {
>      const char *help;
>      void (*user_print)(Monitor *mon, const QObject *data);
>      union {
> -        void (*info)(Monitor *mon);
> +        void (*info)(Monitor *mon, const QDict *qdict);
>          void (*cmd)(Monitor *mon, const QDict *qdict);
>          int  (*cmd_new)(Monitor *mon, const QDict *params, QObject 
> **ret_data);
>          int  (*cmd_async)(Monitor *mon, const QDict *params,
> @@ -824,7 +824,7 @@ static void do_info(Monitor *mon, const QDict *qdict)
>          goto help;
>      }
>  
> -    cmd->mhandler.info(mon);
> +    cmd->mhandler.info(mon, NULL);
>      return;
>  

For now, the new argument is NULL, not an empty dictionary.  Could be
mentioned in the commit message.  Not worth a respin.

[...]