[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snap
From: |
Wenchao Xia |
Subject: |
Re: [Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots |
Date: |
Tue, 25 Dec 2012 13:24:13 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 |
δΊ 2012-12-22 2:49, Juan Quintela ει:
> Wenchao Xia <address@hidden> wrote:
>> +
>> +typedef struct SNTime {
>> + uint32_t date_sec; /* UTC date of the snapshot */
>> + uint32_t date_nsec;
>
> This two fields are just struct timespec, does it makes sense to use it?
>
make sense, I did not notice timespec before, will use it if windows
support timespec too.
>> +
>> +/* Core structure for group snapshots, fill in it and then call the API. */
>> +typedef struct BlkTransactionStates BlkTransactionStates;
>> +
>> +struct BlkTransactionStates {
>> + /* caller input */
>> + bool async;
>
> Why do we have this variable? As far as I can see, we only test its
> value, and set it to false. Are we missing any patch?
>
No, I just put it here as a reserved option. Maybe live block commit
can be considered as async deletion of snapshot, but nevermind I'll
delete it for that it is not supported now.
--
Best Regards
Wenchao Xia
- Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots, (continued)
Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots, Juan Quintela, 2012/12/21
[Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots, Wenchao Xia, 2012/12/17