qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/11] qemu-img: remove parameter filename in co


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 03/11] qemu-img: remove parameter filename in collect_image_info()
Date: Thu, 03 Jan 2013 11:03:34 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0

On 12/29/2012 01:45 AM, Wenchao Xia wrote:
>   Switch the filename getting from parameter to block function,
> now collect_image_info depends only on *bs.
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  qemu-img.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 5a4df3a..d70435f 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -1180,15 +1180,17 @@ static void dump_json_image_info(ImageInfo *info)
>      QDECREF(str);
>  }
>  
> +/* Assume bs is already openned. */

s/openned/opened/

Once that is fixed,
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]