[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/9] target-i386: check/enforce: Check all CPUID.800
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH 5/9] target-i386: check/enforce: Check all CPUID.80000001H.EDX bits |
Date: |
Fri, 4 Jan 2013 13:37:40 -0200 |
I have no idea why PPRO_FEATURES was being ignored on the check of the
CPUID.80000001H.EDX bits. I believe it was a mistake, and it was
supposed to be ~(PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) or just
~CPUID_EXT2_AMD_ALIASES, because some time ago kvm_cpu_fill_host() used
the CPUID instruction directly (instead of
kvm_arch_get_supported_cpuid()).
But now kvm_cpu_fill_host() use kvm_arch_get_supported_cpuid(), and
kvm_arch_get_supported_cpuid() returns all supported bits for
CPUID.80000001H.EDX, even the AMD aliases (that are explicitly copied
from CPUID.01H.EDX), so we can make the code check/enforce all the
CPUID.80000001H.EDX bits.
Signed-off-by: Eduardo Habkost <address@hidden>
---
target-i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index f1a21cf..13075c7 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -967,7 +967,7 @@ static int kvm_check_features_against_host(x86_def_t
*guest_def)
{&guest_def->ext_features, &host_def.ext_features,
~0, ext_feature_name, 0x00000001, R_ECX},
{&guest_def->ext2_features, &host_def.ext2_features,
- ~PPRO_FEATURES, ext2_feature_name, 0x80000001, R_EDX},
+ ~0, ext2_feature_name, 0x80000001, R_EDX},
{&guest_def->ext3_features, &host_def.ext3_features,
~CPUID_EXT3_SVM, ext3_feature_name, 0x80000001, R_ECX}};
--
1.7.11.7
- [Qemu-devel] [PATCH 0/9] target-i386: make "enforce" flag work as it should, Eduardo Habkost, 2013/01/04
- [Qemu-devel] [PATCH 2/9] target-i386: kvm: Enable all supported KVM features for -cpu host, Eduardo Habkost, 2013/01/04
- [Qemu-devel] [PATCH 4/9] target-i386: check/enforce: Do not ignore "hypervisor" flag, Eduardo Habkost, 2013/01/04
- [Qemu-devel] [PATCH 5/9] target-i386: check/enforce: Check all CPUID.80000001H.EDX bits,
Eduardo Habkost <=
- [Qemu-devel] [PATCH 8/9] target-i386: Call kvm_check_features_against_host() only if CONFIG_KVM is set, Eduardo Habkost, 2013/01/04
- [Qemu-devel] [PATCH 6/9] target-i386: check/enforce: Check SVM flag support as well, Eduardo Habkost, 2013/01/04
- [Qemu-devel] [PATCH 7/9] target-i386: check/enforce: Eliminate check_feat field, Eduardo Habkost, 2013/01/04
- [Qemu-devel] [PATCH 9/9] target-i386: check/enforce: Check all feature words, Eduardo Habkost, 2013/01/04
- [Qemu-devel] [PATCH 1/9] target-i386: kvm: -cpu host: Use GET_SUPPORTED_CPUID for SVM features, Eduardo Habkost, 2013/01/04
- [Qemu-devel] [PATCH 3/9] target-i386: check/enforce: Fix CPUID leaf numbers on error messages, Eduardo Habkost, 2013/01/04
- Message not available
- Re: [Qemu-devel] [PATCH 0/9] target-i386: make "enforce" flag work as it should, Anthony Liguori, 2013/01/04