[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] target-i386: Don't set any KVM flag by defa
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] target-i386: Don't set any KVM flag by default if KVM is disabled |
|
Date: |
Fri, 4 Jan 2013 19:25:43 -0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jan 04, 2013 at 07:02:17PM -0200, Eduardo Habkost wrote:
> On Fri, Jan 04, 2013 at 08:47:07PM +0000, Blue Swirl wrote:
> > > {
> > > - kvm_default_features |= kvm_pv_eoi_features;
> > > +#ifdef CONFIG_KVM
> > > + if (kvm_enabled())
> >
> > Missing braces, please read CODING_STYLE and use checkpatch.pl to find
> > problems in patches.
>
> Sorry (again). I will soon send a new version fixing the coding style
> problems.
checkpatch.pl is behaving weirdly, here:
$ git show 193e2f6 | grep 'if (kvm'
+ if (kvm_enabled())
$ git show 193e2f6 | ./scripts/checkpatch.pl -
total: 0 errors, 0 warnings, 19 lines checked
Your patch has no obvious style problems and is ready for submission.
$
--
Eduardo