[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction |
Date: |
Wed, 9 Jan 2013 13:44:33 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jan 07, 2013 at 03:28:06PM +0800, Wenchao Xia wrote:
> This patch switch to internal common API to take group external
> snapshots from qmp_transaction interface. qmp layer simply does
> a translation from user input.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> blockdev.c | 215
> ++++++++++++++++++++++++------------------------------------
> 1 files changed, 87 insertions(+), 128 deletions(-)
An internal API for snapshots is not necessary. qmp_transaction() is
already usable both from the monitor and C code.
The QAPI code generator creates structs that can be accessed directly
from C. qmp_transaction(), BlockdevAction, and BlockdevActionList *is*
the snapshot API. It just doesn't support internal snapshots yet, which
is what you are trying to add.
To add internal snapshot support, define a BlockdevInternalSnapshot type
in qapi-schema.json and add internal snapshot support in
qmp_transaction().
qmp_transaction() was designed with this in mind from the beginning and
dispatches based on BlockdevAction->kind.
The patch series will become much smaller while still adding internal
snapshot support.
Stefan
- [Qemu-devel] [PATCH V2 01/10] block: export function bdrv_find_snapshot(), (continued)
- [Qemu-devel] [PATCH V2 01/10] block: export function bdrv_find_snapshot(), Wenchao Xia, 2013/01/07
- [Qemu-devel] [PATCH V2 04/10] oslib-win32: add lock for time functions, Wenchao Xia, 2013/01/07
- [Qemu-devel] [PATCH V2 04/10] oslib-win32: add lock for time functions, Wenchao Xia, 2013/01/07
- [Qemu-devel] [PATCH V2 06/10] snapshot: implemention of internal common API to take snapshots, Wenchao Xia, 2013/01/07
- [Qemu-devel] [PATCH V2 09/10] snapshot: qmp add blockdev-snapshot-internal-sync interface, Wenchao Xia, 2013/01/07
- [Qemu-devel] [PATCH V2 05/10] snapshot: design of internal common API to take snapshots, Wenchao Xia, 2013/01/07
- [Qemu-devel] [PATCH V2 10/10] snapshot: hmp add internal snapshot support for block device, Wenchao Xia, 2013/01/07
- [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction, Wenchao Xia, 2013/01/07
- Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction, Wenchao Xia, 2013/01/09
- Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction, Stefan Hajnoczi, 2013/01/10
- Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction, Wenchao Xia, 2013/01/11
- Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction, Stefan Hajnoczi, 2013/01/11
- Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction, Wenchao Xia, 2013/01/13
- Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction, Stefan Hajnoczi, 2013/01/14
- Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction, Wenchao Xia, 2013/01/15
[Qemu-devel] [PATCH V2 08/10] snapshot: qmp add internal snapshot transaction interface, Wenchao Xia, 2013/01/07
Re: [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way, Eric Blake, 2013/01/09