[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 31/32] usbredir: Add support for buffered bulk i
From: |
Hans de Goede |
Subject: |
Re: [Qemu-devel] [PATCH 31/32] usbredir: Add support for buffered bulk input (v2) |
Date: |
Wed, 09 Jan 2013 23:04:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Hi,
On 01/09/2013 09:52 PM, Blue Swirl wrote:
<snip>
diff --git a/hw/usb/quirks-ftdi-ids.h b/hw/usb/quirks-ftdi-ids.h
new file mode 100644
index 0000000..57c12ef
--- /dev/null
+++ b/hw/usb/quirks-ftdi-ids.h
@@ -0,0 +1,1255 @@
+/*
+ * vendor/product IDs (VID/PID) of devices using FTDI USB serial converters.
+ * Please keep numerically sorted within individual areas, thanks!
+ *
+ * Philipp Gühring - address@hidden - added the Device ID of the USB relais
+ * from Rudolf Gugler
License information is missing.
Where is this file coming from, Linux?
Yes, it is a one on one copy of linux/drivers/usb/serial/ftdi_sio_ids.h,
so I did not think it would be a good idea to simply slap a copyright header on
top
...
One could argue it is an integral part of linux/drivers/usb/serial/ftdi_sio.c
and use
the copy right headers from there.
Should we use linux-headers instead?
Since this is a copy of an internal kernel header, rather then of one from the
linux/include/linux or linux/include/asm "public" hierarchies it seemed wrong
to me to
use linux-headers for this.
Regards,
Hans
- [Qemu-devel] [PATCH 20/32] usbredir: Add an usbredir_stop_ep helper function, (continued)
- [Qemu-devel] [PATCH 20/32] usbredir: Add an usbredir_stop_ep helper function, Gerd Hoffmann, 2013/01/08
- [Qemu-devel] [PATCH 22/32] usbredir: Add ep_stopped USBDevice method, Gerd Hoffmann, 2013/01/08
- [Qemu-devel] [PATCH 32/32] uhci: stop using portio lists, Gerd Hoffmann, 2013/01/08
- [Qemu-devel] [PATCH 28/32] usb/ehci: Move capsbase and opregbase into SysBus EHCI class, Gerd Hoffmann, 2013/01/08
- [Qemu-devel] [PATCH 24/32] usbredir: Add usbredir_init_endpoints() helper, Gerd Hoffmann, 2013/01/08
- [Qemu-devel] [PATCH 16/32] uhci: Maximize how many frames we catch up when behind, Gerd Hoffmann, 2013/01/08
- [Qemu-devel] [PATCH 27/32] usb/ehci: Clean up SysBus and PCI EHCI split, Gerd Hoffmann, 2013/01/08
- [Qemu-devel] [PATCH 18/32] usb: Fix usb_ep_find_packet_by_id, Gerd Hoffmann, 2013/01/08
- [Qemu-devel] [PATCH 31/32] usbredir: Add support for buffered bulk input (v2), Gerd Hoffmann, 2013/01/08
- Re: [Qemu-devel] [PULL 00/32] usb patch queue, Anthony Liguori, 2013/01/08