[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 02/12] target-i386: Don't set any KVM flag by defa
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [RFC 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled |
Date: |
Thu, 10 Jan 2013 22:03:39 -0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Jan 11, 2013 at 12:07:40AM +0100, Igor Mammedov wrote:
[...]
> > @@ -1343,13 +1337,15 @@ static int cpu_x86_parse_featurestr(x86_def_t
> > *x86_cpu_def, char *features)
> > unsigned int i;
> > char *featurestr; /* Single 'key=value" string being parsed */
> > /* Features to be added */
> > - FeatureWordArray plus_features = {
> > - [FEAT_KVM] = kvm_default_features,
> > - };
> > + FeatureWordArray plus_features = { 0 };
> > /* Features to be removed */
> > FeatureWordArray minus_features = { 0 };
> > uint32_t numvalue;
> >
> > + if (kvm_enabled()) {
> > + plus_features[FEAT_KVM] = kvm_default_features;
> > + }
> While touching it please move setting defaults to cpu_x86_register() or
> cpu_x86_find_by_name() to so that cpu_x86_parse_featurestr() would deal only
> with custom settings.
OK, I will do it in the next version.
--
Eduardo
- Re: [Qemu-devel] [RFC 12/12] pc: Generate APIC IDs according to CPU topology, (continued)
- [Qemu-devel] [RFC 04/12] kvm: Create kvm_arch_vcpu_id() function, Eduardo Habkost, 2013/01/09
- [Qemu-devel] [RFC 07/12] target-i386/cpu: Introduce apic_id_for_cpu() function, Eduardo Habkost, 2013/01/09
- [Qemu-devel] [RFC 10/12] tests: Support target-specific unit tests, Eduardo Habkost, 2013/01/09
- [Qemu-devel] [RFC 02/12] target-i386: Don't set any KVM flag by default if KVM is disabled, Eduardo Habkost, 2013/01/09
- [Qemu-devel] [RFC 11/12] target-i386: Topology & APIC ID utility functions, Eduardo Habkost, 2013/01/09
- Re: [Qemu-devel] [RFC 00/12] target-i386: Fix APIC-ID-based topology (v4), Eduardo Habkost, 2013/01/17