[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/10] sun4u: create VGA card after ISA bus
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 04/10] sun4u: create VGA card after ISA bus |
Date: |
Sat, 12 Jan 2013 16:58:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 12.01.2013 12:42, schrieb Blue Swirl:
> On Thu, Jan 10, 2013 at 7:30 PM, Hervé Poussineau <address@hidden> wrote:
>> Andreas Färber a écrit :
>>
>>> Am 04.01.2013 22:29, schrieb Hervé Poussineau:
>>>>
>>>> Signed-off-by: Hervé Poussineau <address@hidden>
>>>> ---
>>>> hw/sun4u.c | 3 ++-
>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>>
>>> Doesn't look wrong to me, cc'ing Blue. I figure this is for 07/10,
>>> which switches to isa_register_portio_list().
>>
>>
>> Indeed.
>> ISA bus is created in pci_ebus_init(). VGA card registers some ISA I/O
>> ports, so an ISA bus must be present.
>
> OK by me.
Thanks, applied to memory-ioport branch (with an additional explanatory
sentence in the commit message):
https://github.com/afaerber/qemu-cpu/commits/memory-ioport
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 01/10] ppc/newworld: add ISA bus, required by VGA card, (continued)
- [Qemu-devel] [PATCH 01/10] ppc/newworld: add ISA bus, required by VGA card, Hervé Poussineau, 2013/01/04
- [Qemu-devel] [PATCH 02/10] ppc/oldworld: add ISA bus, required by VGA card, Hervé Poussineau, 2013/01/04
- [Qemu-devel] [PATCH 03/10] uhci: stop using portio lists, Hervé Poussineau, 2013/01/04
- [Qemu-devel] [PATCH 04/10] sun4u: create VGA card after ISA bus, Hervé Poussineau, 2013/01/04
[Qemu-devel] [PATCH 05/10] xen_platform: do not use old_portio-style callbacks, Hervé Poussineau, 2013/01/04
[Qemu-devel] [PATCH 07/10] vga/qxl: do not use portio_list_init/portio_list_add, Hervé Poussineau, 2013/01/04
[Qemu-devel] [PATCH 08/10] isa: use memory regions instead of portio_list_* functions, Hervé Poussineau, 2013/01/04
[Qemu-devel] [PATCH 09/10] ioport: remove now useless portio_list_* functions, Hervé Poussineau, 2013/01/04
[Qemu-devel] [PATCH 10/10] memory: remove old_portio-style callbacks support, Hervé Poussineau, 2013/01/04