Re: [Qemu-devel] [PATCH 10/20] mirror: add buf-size argument to drive-mirror

[Stefan Hajnoczi]

On Wed, Dec 12, 2012 at 02:46:29PM +0100, Paolo Bonzini wrote:
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index d8faad0..97c52c9 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -939,7 +939,7 @@ EQMP
>          .name       = "drive-mirror",
>          .args_type  = "sync:s,device:B,target:s,speed:i?,mode:s?,format:s?,"
>                        "on-source-error:s?,on-target-error:s?,"
> -                      "granularity:i?",
> +                      "buf-size:i?,granularity:i?",

granularity was also added in this patch series, so this doesn't matter,
but in general it's nicer to append optional arguments on the end.  This
way, command option ordering doesn't change arbitrarily - that could
confuse users.

Stefan