[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] scsi-disk: qemu_vfree(NULL) is fine, simpli
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify |
Date: |
Tue, 15 Jan 2013 16:17:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 |
Il 15/01/2013 14:23, Markus Armbruster ha scritto:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> hw/scsi-disk.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
> index f8d7ef3..96db9a7 100644
> --- a/hw/scsi-disk.c
> +++ b/hw/scsi-disk.c
> @@ -85,9 +85,7 @@ static void scsi_free_request(SCSIRequest *req)
> {
> SCSIDiskReq *r = DO_UPCAST(SCSIDiskReq, req, req);
>
> - if (r->iov.iov_base) {
> - qemu_vfree(r->iov.iov_base);
> - }
> + qemu_vfree(r->iov.iov_base);
> }
>
> /* Helper function for command completion with sense. */
>
Acked-by: Paolo Bonzini <address@hidden>
- [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree(), Markus Armbruster, 2013/01/15
- [Qemu-devel] [PATCH 3/4] win32-aio: Fix how win32_aio_process_completion() frees buffer, Markus Armbruster, 2013/01/15
- [Qemu-devel] [PATCH 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify, Markus Armbruster, 2013/01/15
- Re: [Qemu-devel] [PATCH 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree(), Kevin Wolf, 2013/01/15
- Re: [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree(), Stefan Hajnoczi, 2013/01/15