Re: [Qemu-devel] [PULL] pci,virtio

[Andreas Färber]

Am 15.01.2013 17:32, schrieb Michael S. Tsirkin:
> On Tue, Jan 15, 2013 at 11:09:22AM +0100, Andreas Färber wrote:
>> Am 13.01.2013 11:47, schrieb Michael S. Tsirkin:
>>>       virtio-pci: cache msix messages
>>
>> This broke the build with PowerKVM:
>>
>>   LINK  ppc64-softmmu/qemu-system-ppc64
>> ../hw/virtio-pci.o: In function `kvm_virtio_pci_vq_vector_unmask':
>> /home/andreas/QEMU/qemu/hw/virtio-pci.c:622: undefined reference to
>> `kvm_irqchip_update_msi_route'
>> collect2: error: ld returned 1 exit status
>> make[1]: *** [qemu-system-ppc64] Fehler 1
>> make: *** [subdir-ppc64-softmmu] Fehler 2
>>
>> Can you supply a fix? It's not obvious to me how.
> 
> I'm not sure how to build this. Can you tell me pls?

Ideally Daniel would set up your pci branch to build on the revived ppc
buildbot (and on s390, thinking of virtio).

When on a Linux/ppc host the KVM headers are detected, nothing special
needs to be configured to build that code. Cross-compilation should work
as well but obviously needs the right environment; same for a ppc chroot
with linux-user+binfmt.

> Maybe the below helps?
> 
> kvm: add stub for kvm_irqchip_update_msi_route
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>

Tested-by: Andreas Färber <address@hidden>

Great, together with Blue's bswap patch this fixes the build for me.
Thanks for the quick response!

Regards,
Andreas

> diff --git a/kvm-all.c b/kvm-all.c
> index fc0c6e7..bac67da 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -1182,6 +1182,11 @@ static int kvm_irqchip_assign_irqfd(KVMState *s, int 
> fd, int virq, bool assign)
>  {
>      abort();
>  }
> +
> +int kvm_irqchip_update_msi_route(KVMState *s, int virq, MSIMessage msg)
> +{
> +    return -ENOSYS;
> +}
>  #endif /* !KVM_CAP_IRQ_ROUTING */
>  
>  int kvm_irqchip_add_irqfd_notifier(KVMState *s, EventNotifier *n, int virq)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg