Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format

[Stefan Weil]

Am 17.01.2013 22:28, schrieb Eric Blake:
> On 01/17/2013 01:45 PM, Stefan Weil wrote:
>    
> > These patches improve the error report if the file format was
> > specified explicitly (example: -drive file=myfile,format=qcow2)
> > and the given format does not match the real format.
> >
> > They fix those bugs:
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=556482
> > https://bugs.launchpad.net/qemu/+bug/1090600
> >
> > Changes in v2:
> >
> > * Use error code EMEDIUMTYPE instead of inventing a new one.
> >      
> Alas, EMEDIUMTYPE is non-standard, and doesn't exist outside of Linux.
> If you are providing fallbacks for half the platforms because you don't
> want to use a standard errno value, then why not go all the way and use
> a fallback for all platforms.
>    

That's what I did in v1 of my patches: it used BDRV_WRONG_FORMAT.

I didn't introduce a EFILEFORMAT because it looks like
something used outside of the QEMU world (which is not true).

If EFILEFORMAT (or any other new name) is preferred,
I won't object. In this case, I can either send a new patch series,
or whoever commits my patches can do a simple replace operation.

Regards,
Stefan W.