Re: [Qemu-devel] [PATCH] tests: adjust gcov variables for directory movement

[Paolo Bonzini]

Il 17/01/2013 21:43, Blue Swirl ha scritto:
>> >         Blue, can you look at introducing a common variable for the 
>> > coroutine
>> >         backend?  Like
>> >
>> >         coroutine-backend-y = gthread
>> >         coroutine-backend-$(CONFIG_SIGALTSTACK_COROUTINE) = sigaltstack
>> >         coroutine-backend-$(CONFIG_UCONTEXT_COROUTINE) = ucontext
>> >         coroutine-backend-$(CONFIG_WIN32) = win32
>> >
>> >         and using it in both Makefile.objs and tests/Makefile.
>> >         Another alternative is to use $(filter) to pick the one file that
>> >         is actually part of $(block-obj-y).  Thanks!
> OK. Related to this, perhaps it would be better to rearrange the test
> directory so that in most cases there is 1:1 relation with a test and
> the code that it tests, for example qobject/qdict.c would be tested by
> tests/qobject/qdict.c. This would simplify the Makefile a lot.

I'd prefer tests/qobject/check-qdict.c, but that's the idea yes.

> Then we could also add a dummy test for each source file mechanically
> to see how low the test coverage really is and to encourage writing
> more of them.

True, one of the points of introducing libqemuutil.a is to easily
identify code that can be unit tested and headers where gtk-doc comments
can be added.

Of course there can be other unit tests (e.g. main loop, coroutines,
QOM, etc.) but that's the low-hanging fruit.

Paolo