[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/27] More source reorganization and build syste
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PULL 00/27] More source reorganization and build system TLC |
|
Date: |
Sat, 19 Jan 2013 11:43:34 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 19/01/2013 11:21, Blue Swirl ha scritto:
>> > Does the function really needs to be called qemu_vmalloc? If not,
>> > having the same name for two different things is bad.
> I've just sent a patch to fix this.
>
> But new code could be introduced that used qemu_vmalloc() so I'm not
> sure this approach is the best.
Right now there isn't even a matching qemu_vfree(); the implementation
in util/oslib-posix.c would be used and that would use free() instead of
munmap(). So, code that happened to use qemu_vmalloc() outside bsd-user
would be completely wrong. It was a time bomb, and it's a good thing
that it was exposed.
Paolo
- Re: [Qemu-devel] [PATCH 25/27] build: some simplifications for "trace/Makefile.objs", (continued)
- [Qemu-devel] [PATCH 26/27] build: fold trace-obj-y into libqemuutil.a, Paolo Bonzini, 2013/01/12
- [Qemu-devel] [PATCH 22/27] build: move base QAPI files to libqemuutil.a, Paolo Bonzini, 2013/01/12
- [Qemu-devel] [PATCH 23/27] build: move version-obj-y to the generic LINK rule, Paolo Bonzini, 2013/01/12
- [Qemu-devel] [PATCH 27/27] build: improve quiet output for .stp rules, Paolo Bonzini, 2013/01/12
- [Qemu-devel] [PATCH 24/27] build: remove coroutine-obj-y, Paolo Bonzini, 2013/01/12
- Re: [Qemu-devel] [PULL 00/27] More source reorganization and build system TLC, Stefan Hajnoczi, 2013/01/14
- Re: [Qemu-devel] [PULL 00/27] More source reorganization and build system TLC, Andreas Färber, 2013/01/18