Re: [Qemu-devel] [PATCH v2 1/3] move socket_set_nodelay to osdep.c

[Stefan Hajnoczi]

On Mon, Jan 21, 2013 at 09:23:28AM +0900, MORITA Kazutaka wrote:
> diff --git a/slirp/tcp_subr.c b/slirp/tcp_subr.c
> index 1542e43..abc6662 100644
> --- a/slirp/tcp_subr.c
> +++ b/slirp/tcp_subr.c
> @@ -429,8 +429,7 @@ tcp_connect(struct socket *inso)
>       setsockopt(s,SOL_SOCKET,SO_REUSEADDR,(char *)&opt,sizeof(int));
>       opt = 1;
>       setsockopt(s,SOL_SOCKET,SO_OOBINLINE,(char *)&opt,sizeof(int));
> -     opt = 1;
> -     setsockopt(s,IPPROTO_TCP,TCP_NODELAY,(char *)&opt,sizeof(int));
> +    socket_set_nodelay(s);

This function still uses tabs for indentation.  The line you added uses
4 spaces (QEMU coding style) but now this single line may be
inconsistent.  I suggest using tab for this line so it fits in with the
existing code.