Re: [Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192

[Markus Armbruster]

Alon Levy <address@hidden> writes:

> This is a simpler solution to 869981, where migration breaks since qxl's

s/869981/RHBZ#869981/

> rom bar size has changed. Instead of ignoring fields in QXLRom, which is what 
> has

Long line, please wrap.

> actually changed, we remove some of the modes, a mechanism already
> accounted for by the guest. The modes left allow for portrait and
> landscape only modes, corresponding to orientations 0 and 1.
> Orientations 2 and 3 are dropped.
>
> Added assert so that rom size will fit the future QXLRom increases via
> spice-protocol changes.
>
> This patch has been tested with 6.1.0.10015. With the newer 6.1.0.10016
> there are problems with both "(flipped)" modes prior to the patch, and
> the patch loses the ability to set "Portrait" modes. But this is a
> separate bug to be fixed in the driver, and besides the patch doesn't
> affect the new arbitrary mode setting functionality.
>
> Signed-off-by: Alon Levy <address@hidden>