[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192 |
Date: |
Tue, 22 Jan 2013 18:19:54 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Alon Levy <address@hidden> writes:
> This is a simpler solution to 869981, where migration breaks since qxl's
s/869981/RHBZ#869981/
> rom bar size has changed. Instead of ignoring fields in QXLRom, which is what
> has
Long line, please wrap.
> actually changed, we remove some of the modes, a mechanism already
> accounted for by the guest. The modes left allow for portrait and
> landscape only modes, corresponding to orientations 0 and 1.
> Orientations 2 and 3 are dropped.
>
> Added assert so that rom size will fit the future QXLRom increases via
> spice-protocol changes.
>
> This patch has been tested with 6.1.0.10015. With the newer 6.1.0.10016
> there are problems with both "(flipped)" modes prior to the patch, and
> the patch loses the ability to set "Portrait" modes. But this is a
> separate bug to be fixed in the driver, and besides the patch doesn't
> affect the new arbitrary mode setting functionality.
>
> Signed-off-by: Alon Levy <address@hidden>
- [Qemu-devel] [PATCH v2 1/2] qxl: stop using non revision 4 rom fields for revision < 4, (continued)
- [Qemu-devel] [PATCH v2 1/2] qxl: stop using non revision 4 rom fields for revision < 4, Alon Levy, 2013/01/16
- [Qemu-devel] [PATCH v2 2/2] qxl: change rom size to 8192, Alon Levy, 2013/01/16
- Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors, Gerd Hoffmann, 2013/01/17
- Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors, Alon Levy, 2013/01/17
- Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors, Gerd Hoffmann, 2013/01/17
- Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors, Alon Levy, 2013/01/20
- Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors, Gerd Hoffmann, 2013/01/21
- Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors, Alon Levy, 2013/01/21
- [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4, Alon Levy, 2013/01/21
- [Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192, Alon Levy, 2013/01/21
- Re: [Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4, Alon Levy, 2013/01/21
- Re: [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4, Gerd Hoffmann, 2013/01/21
- Re: [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4, Markus Armbruster, 2013/01/22