[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] scripts: extract ELF magics from qemu-binfm
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] scripts: extract ELF magics from qemu-binfmt-conf.sh |
Date: |
Thu, 24 Jan 2013 22:40:50 +0100 |
Am 24.01.2013 um 21:10 schrieb Laurent Vivier <address@hidden>:
> Le jeudi 24 janvier 2013 à 19:07 +0100, Alexander Graf a écrit :
>> On 20.01.2013, at 00:20, Laurent Vivier wrote:
>>
>>> Signed-off-by: Laurent Vivier <address@hidden>
> [...]
>>> index 0da2618..6235637
>>> --- a/scripts/qemu-binfmt-conf.sh
>>> +++ b/scripts/qemu-binfmt-conf.sh
>>> @@ -1,69 +1,59 @@
>>> #!/bin/sh
>>> # enable automatic i386/ARM/M68K/MIPS/SPARC/PPC/s390 program execution by
>>> the kernel
>>>
>>> +MAGIC=$(dirname $(readlink -f "$0"))/binfmts-magic
>>
>> Wouldn't that break with $0 is in PATH?
>
> Yes, it breaks. But the purpose of this script is not to be installed
> but to help Qemu developers to create runnable linux root file system.
> If this script is installed, the good way to do this is to use the
> install base prefix.
Well, we could patch $prefix into the script on make install. In openSUSE, we
do install this script and having a streamlined approach for that would be good
imho.
Alex
>
> Regards,
> Laurent
> --
> "Just play. Have fun. Enjoy the game."
> - Michael Jordan
>