[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 02/13] qdev: change first argument of qbus_cr
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v4 02/13] qdev: change first argument of qbus_create_inplace to void * |
Date: |
Fri, 25 Jan 2013 15:04:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 25.01.2013 14:12, schrieb Paolo Bonzini:
> Make it clear that no BUS() macro is needed in the callers (in fact it
> wouldn't work because the object has not been initialized yet with the
> right class).
>
> Suggested-by: Andreas Faerber <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
Acked-by: Andreas Färber <address@hidden>
But we should adjust most current callers then:
hw/ide/qdev.c: qbus_create_inplace(&idebus->qbus, TYPE_IDE_BUS, dev,
NULL);
..._inplace(idebus, ...)
hw/intel-hda.c: qbus_create_inplace(&bus->qbus, TYPE_HDA_BUS, dev, NULL);
hw/ipack.c: qbus_create_inplace(&bus->qbus, TYPE_IPACK_BUS, parent,
name);
hw/pci/pci.c: qbus_create_inplace(&bus->qbus, TYPE_PCI_BUS, parent,
name);
hw/pci/pci_bridge.c: qbus_create_inplace(&sec_bus->qbus,
TYPE_PCI_BUS, &dev->qdev,
hw/s390-virtio-bus.c: qbus_create_inplace((BusState *)bus,
TYPE_VIRTIO_S390_BUS, qdev, NULL);
..._inplace(bus, ...)
hw/s390x/event-facility.c:
qbus_create_inplace(&event_facility->sbus.qbus,
hw/scsi-bus.c: qbus_create_inplace(&bus->qbus, TYPE_SCSI_BUS, host,
NULL);
hw/usb/bus.c: qbus_create_inplace(&bus->qbus, TYPE_USB_BUS, host, NULL);
hw/usb/dev-smartcard-reader.c: qbus_create_inplace(&s->bus.qbus,
TYPE_CCID_BUS, &dev->qdev, NULL);
hw/virtio-pci.c: qbus_create_inplace((BusState *)bus,
TYPE_VIRTIO_PCI_BUS, qdev, NULL);
hw/virtio-serial-bus.c: qbus_create_inplace(&vser->bus.qbus,
TYPE_VIRTIO_SERIAL_BUS, dev, NULL);
Should I send a follow-up patch for that or do you want to squash it
into yours to show the utility of your change?
Another caller with a cast is arriving in today's ppc pull (ADB in
cuda.c - 10/21).
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH for-1.4 v4 00/12] qdev: correct reference counting, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 06/13] qdev: add reference count to a device for the BusChild, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 03/13] pci: use qbus_create in pci_bus_new, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 01/13] qdev: remove duplication between qbus_create and qbus_create_inplace, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 04/13] qom: preserve object while unparenting it, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 02/13] qdev: change first argument of qbus_create_inplace to void *, Paolo Bonzini, 2013/01/25
- Re: [Qemu-devel] [PATCH v4 02/13] qdev: change first argument of qbus_create_inplace to void *,
Andreas Färber <=
- [Qemu-devel] [PATCH v4 05/13] qom: document reference counting of link properties, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 08/13] qdev: move unrealization of devices from finalize to unparent, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 09/13] qdev: add reference for the bus while it is referred to by the DeviceState, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 11/13] qdev: drop extra references at creation time, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 12/13] cpu: do not use object_delete, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 10/13] qdev: inline object_delete into qbus_free/qdev_free, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 07/13] qdev: move deletion of children from finalize to unparent, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v4 13/13] qom: remove object_delete, Paolo Bonzini, 2013/01/25